go-localstack
go-localstack copied to clipboard
Add WithRegistry option
Because of DockerHub limits sometimes we need to set our own registry to download localstack.
Hi, thank you for the PR. Could you please provide tests?
Codecov Report
Merging #569 (b1cd7f1) into main (f37d98e) will decrease coverage by
2.92%. The diff coverage is33.33%.
@@ Coverage Diff @@
## main #569 +/- ##
==========================================
- Coverage 97.63% 94.71% -2.93%
==========================================
Files 2 2
Lines 254 265 +11
==========================================
+ Hits 248 251 +3
- Misses 4 11 +7
- Partials 2 3 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| localstack.go | 94.61% <33.33%> (-2.98%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 549d856...b1cd7f1. Read the comment docs.
@bdandy ping
It seems like changes were added to build image instead of fetching it, so MR won't work anymore
So we can close this here?
It seems like with new code it's not possible to choose a registry to build the docker container from (for example gitlab proxy), like it was before.
I'm not sure why it was changed to build container instead of pull.
Anyway this can be closed