go-localstack icon indicating copy to clipboard operation
go-localstack copied to clipboard

Add WithRegistry option

Open bdandy opened this issue 3 years ago • 2 comments

Because of DockerHub limits sometimes we need to set our own registry to download localstack.

bdandy avatar Jun 17 '22 12:06 bdandy

Hi, thank you for the PR. Could you please provide tests?

elgohr avatar Jun 24 '22 16:06 elgohr

Codecov Report

Merging #569 (b1cd7f1) into main (f37d98e) will decrease coverage by 2.92%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   97.63%   94.71%   -2.93%     
==========================================
  Files           2        2              
  Lines         254      265      +11     
==========================================
+ Hits          248      251       +3     
- Misses          4       11       +7     
- Partials        2        3       +1     
Impacted Files Coverage Δ
localstack.go 94.61% <33.33%> (-2.98%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 549d856...b1cd7f1. Read the comment docs.

codecov[bot] avatar Jun 24 '22 20:06 codecov[bot]

@bdandy ping

elgohr avatar Sep 18 '22 09:09 elgohr

It seems like changes were added to build image instead of fetching it, so MR won't work anymore

bdandy avatar Sep 29 '22 10:09 bdandy

So we can close this here?

elgohr avatar Sep 30 '22 14:09 elgohr

It seems like with new code it's not possible to choose a registry to build the docker container from (for example gitlab proxy), like it was before.

I'm not sure why it was changed to build container instead of pull.

Anyway this can be closed

bdandy avatar Oct 18 '22 10:10 bdandy