Lars Gohr

Results 58 comments of Lars Gohr

I'm thinking about declining the PR. The Dockerfile is used in context of testing the action within CI/CD. The image will never be in production, but be gone after testing....

Alright I totally got that for production related images. For testing images these findings seem odd.

I measured it multiple times - the image builds at my machine in around 1:15 min. Main tends to be a little quicker (1:10 - 1:15 min). Ironically the PR...

Could return nil, but this would break the interface See https://github.com/nathan-osman/go-sunrise/blob/master/sunrise_test.go#L39

Did you try using a [label](https://docs.docker.com/reference/dockerfile/#label) that is filled using a buildarg?

Hi, thank you for bringing this up. This project is based on the Localstack Docker image. AWS Batch is part of the localstack pro image (https://docs.localstack.cloud/references/coverage/coverage_batch/). As I'm doing this...

PRs are always welcome. Anyhow, there would have to be tests for verification - which would require a pro license in CI/CD.

Did you try to set `GH_HOST` / `GH_ENTERPRISE_TOKEN`? https://cli.github.com/manual/gh_help_environment