gianlucaelia
gianlucaelia
@capital-G thanks again for all the work, I feel we are almost through! So, after the above conversations are resolved, I think we need to address one last thing: CSS...
Thank you for bearing with me through all this :D There is one more unresolved conversation about the extension badge, that maybe you have lost in this long series of...
Looks good to me! After you push the class names, and we resolve the two small things above, I'll give it another round of review and testing. Thanks!
Great, thanks so much for all the work, I don't have any other structural changes to propose. Now we need to double check all themes for readability issues and eventually...
I went through all themes and made some little changes, which I think improve readability. Try them out and let me know: ```diff themes/classic.css - --color-fg-100: #ccc; + --color-fg-100: #eee;...
ok, but then maybe put #7b8d8d for links? They would become a little bit more visible and I think it's nice Also, do you experience flashes (especially with dark themes)...
> Thats to be expected because the default theme is loaded within the DOM and JS replaces the CSS file with the one stored in localStorage. We could call this...
Thanks for the fast reaction, I updated the patch after your last commits, because we still need to move some around (and add a missing since we are here): https://gist.github.com/elgiano/c4e56a98a28889cd7b2140c97260c800
Great, no more flashes :) Now the only thing left is documentation, and I agree with you we shouldn't put css class names in there. I was thinking of a...
I've written some documentation, here is a patch: https://gist.github.com/elgiano/c4e56a98a28889cd7b2140c97260c800 Basically I've removed the CSS Styling paragraph from SCDocHTMLRenderer, and added a link to a new document in Reference/SCDocStyling: ``` title::...