far2l icon indicating copy to clipboard operation
far2l copied to clipboard

Ctrl/Alt+RussianLetter not working in wx3.0 with some keys

Open unxed opened this issue 3 years ago • 3 comments

Alt+RussianLetter quick search is not working in wx3.0 with some keys. Whose are б, ю, ж, э, х, ъ at least.

Same problem with Ctrl+ю — marco recording do not starts in Russian keyboard layout. Ctrl hotkeys with other letter keys listed above does not work also.

unxed avatar Jan 24 '22 01:01 unxed

Fix for Alt+NonLatinLetters that we used for wx 3.1.3+ is working with wx 3.0.5+ also. On Ubuntu 20.04 it even works with wx 3.0.4 as relevant changes are backported from 3.0.5 there — see libwxgtk3.0-gtk3-dev (3.0.4+dfsg-15build1) package details, relevant changes are in debian/patches/upstream-changes-since-3.0.4.patch.

PRs with different solutions for this problem: #1212 — detect non latin kb events support by first happened event #1214 — detect non latin kb events support by wx version #1218 — detect non latin kb events support by wx version, most simple one

Closely related issue is Ctrl+. not working in non-Latin layouts. Fix for that is also presents in first two of PRs mentioned above.

Change in wx fixing non latin key events required for those PRs to work presents in wx 3.0.5+, 3.1.3+ and also in 3.0.4 on Ubuntu 20 and derivatives (exact commit to 3.0 branch).

Related wx issues: https://github.com/wxWidgets/wxWidgets/issues/18054 https://github.com/wxWidgets/wxWidgets/issues/17643 https://github.com/wxWidgets/wxWidgets/issues/18637 https://github.com/wxWidgets/wxWidgets/issues/22058

unxed avatar Jan 28 '22 13:01 unxed

Alt issue fixed in https://github.com/elfmz/far2l/commit/2c0042811df158eecee4a3d34bb514bfc611a2ab

As for Ctrl issue, not sure if it's better to open another ticket or rename this one

unxed avatar Jan 30 '22 00:01 unxed

More specific and compact solution for Ctrl problem: https://github.com/elfmz/far2l/pull/1221

unxed avatar Jan 30 '22 01:01 unxed

Fixed in #1569

unxed avatar Apr 05 '23 13:04 unxed