laravel-geo icon indicating copy to clipboard operation
laravel-geo copied to clipboard

Drop explicit call to DB facade that may not be available

Open trea opened this issue 7 years ago • 2 comments

Hello!

Thanks for your work on this package!

This PR drops references to the DB facade. I ran into an issue with this on a Lumen project that doesn't use Facades where there was a "Class 'DB' not found" exception thrown. I noticed that the methods being called are actually on the Connection, so I opted to use the instance of the Connection that the model has access to anyway, rather than calling the DB facade. :smile:

Thanks!

trea avatar Oct 14 '17 07:10 trea

Sorry for the late response! Thanks for the PR, i totally get what you mean since i encountered similar problems when using Laravel packages within Lumen. We will test this out and eventually merge the PR, but it should be ok out of the box since the mod is clear and simple.

desh901 avatar Nov 07 '17 08:11 desh901

You're welcome! No problem on the response time, appreciate you taking the time to look at the contribution!

trea avatar Nov 07 '17 23:11 trea