wingpanel-indicator-notifications icon indicating copy to clipboard operation
wingpanel-indicator-notifications copied to clipboard

Introduce keep-notifications key

Open teamcons opened this issue 3 months ago • 2 comments

introduce a key to check at saving time whether to save or not, allowing to control whether to keep notification accross reboots

the DE should control and limit behaviours of apps who do not tidy up behind them. the setting could be exposed in the UI in the privacy settings

Not checking at load time because it would mean notifications are still stored despite user not wanting to.

teamcons avatar Oct 04 '25 17:10 teamcons

I'm personally -1 on this. I really don't like doing workarounds for misbehaving apps. It prevents the problem from actually being solved at the source and just kicks the can downstream instead

But more importantly session end is a really arbitrary time frame. If a housekeeping feature for notifications should exist, it should behave like other housekeeping settings and clean up notifications some specific duration after they were sent

If you just want to arbitrarily clear all notifications there is already a clear notifications button

danirabbit avatar Oct 29 '25 18:10 danirabbit

I'm personally -1 on this. I really don't like doing workarounds for misbehaving apps. It prevents the problem from actually being solved at the source and just kicks the can downstream instead

It is unrealistic to assume all apps behave, tidy up behind themselves, and dont leave informations behind them Theres reasons apps cant place themselves, cant keep_on_top themselves, and cant record the whole screen at all time themselves.

But more importantly session end is a really arbitrary time frame. If a housekeeping feature for notifications should exist, it should behave like other housekeeping settings and clean up notifications some specific duration after they were sent

If you just want to arbitrarily clear all notifications there is already a clear notifications button

I think a handy DE is one that doesnt require me to manually tidy it regularly (not even mentioning the years old bug which has wingpanel going slower over time if notifications arent emptied)

session end is when user is finished with the computer.

If you just want to arbitrarily clear all notifications there is already a clear notifications button

Why then does these exist in privacy if we can do it manually?

image

teamcons avatar Oct 29 '25 18:10 teamcons

I personally don't think that it's misbehavior that some apps does not clear their notifications on reboot. I feel rather convenience that unread notifications from my friends remain when my iPhone runs out of battery and iOS reboots when I plugged it in, for example. Also, I feel keeping notifications on reboot be a sort of Always Saved.

Also I personally don't think that clearing all notifications resolves some privacy problem. Users who cares privacy would probably enable DND or turn off the notification itself of the app they don't want entirely.

ryonakano avatar Nov 28 '25 14:11 ryonakano

I personally don't think that it's misbehavior that some apps does not clear their notifications on reboot. I feel rather convenience that unread notifications from my friends remain when my iPhone runs out of battery and iOS reboots when I plugged it in, for example. Also, I feel keeping notifications on reboot be a sort of Always Saved.

Also I personally don't think that clearing all notifications resolves some privacy problem. Users who cares privacy would probably enable DND or turn off the notification itself of the app they don't want entirely.

DnD keeps notifications though

You cannot turn off the notifications of all apps, so if an app is broken you are at its mercy:

Also even eOS apps arent dealing with their notifications properly

It is left as a housekeeping task to the user. The onus is on the user

And if you do not do that, Wingpanel borks itself and the whole DE. That was noticed by users who had DnD enabled

It also doesnt answer the question: why do we clear some stuff out and no others ? Why is there housekeeping for the trash but not for notifications? Should i tell my grandma to click every week the clear button?

I see the notifications being there, and several users being told "its there bc its useful, we cant let user choose bc idkwöeighl its useful, and apps are broken if they dont clear up, including our own" is absurd.

The DE has to moderate those behaviours, and it fails if it does not allow to do so.

im not the only one who wanna set housekeeping for notifications. Deciding how long to keep those even make the feature of keeping notifications relevant - over enough time it is just noise.

Im not even asking to remove persistence, but to treat this as another housekeeping choice

teamcons avatar Nov 28 '25 18:11 teamcons

I personally don't think that it's misbehavior that some apps does not clear their notifications on reboot

@ryonakano I agree with you on this. It makes sense for notifications to persist across sessions for as long as they are still relevant. It seems like this branch is trying to workaround that some apps aren't withdrawing their motivations when they are no longer relevant and/or the bug that prevents notifications from a previous session from being withdrawn.

Why is there housekeeping for the trash but not for notifications?

@teamcons To me this doesn't feel like a good workaround because session restart is arbitrary. It isn't related to whether or not the notification is still relevant and unlike other housekeeping settings, it isn't related to an actual amount of time that has passed since the notification was sent. Session restart could happen when a notification is 30 days old or 30 seconds old.

I wouldn't be as opposed to a feature that cleared notifications 24 hours after they were sent (for example). But I don't think clearing all notifications on session restart is a good solution

danirabbit avatar Nov 28 '25 21:11 danirabbit

It seems like this branch is trying to workaround that some apps aren't withdrawing their motivations when they are no longer relevant and/or the bug that prevents notifications from a previous session from being withdrawn.

it is also working around the fact that the DE is piling up stuff over time (and borking itself as a byproduct too)

@teamcons To me this doesn't feel like a good workaround because session restart is arbitrary. It isn't related to whether or not the notification is still relevant and unlike other housekeeping settings, it isn't related to an actual amount of time that has passed since the notification was sent. Session restart could happen when a notification is 30 days old or 30 seconds old.

I repeat my statement about session start or end:

session end is when user is finished with the computer.

which makes it relevant for the DE to clear session stuff that is irrelevant because the user has decided to terminate the session. thats like saying doing package updates on shutdown is arbitrary

it is a better workaround than nothing at all. Several people have come forward to express them not wanting this behaviour, over time.

I am offering a patchup that does the minimum amount of change to keep people happy, to let the default unchanged, and have a DE that doesnt bork itself.

I can come up with a more complex solution to add cleanup in the settings-daemon, and parse the session file in cache (or replace it with something more proper) but it would have been much better to tell me "id rather have that" from the start - arguing eats away dev time that is offered to you for free, and leaves a bad taste that doesnt make me wanna offer it again.

Like a pr in session-daemon might as well yield the same result. At least on another project it leads to something.

teamcons avatar Nov 29 '25 00:11 teamcons

session end is when user is finished with the computer

This is not really true. People don't really turn off their devices anymore. So session end more likely means your battery died (in which case you really don't want to be deleting things) or you ran system updates

the DE is piling up stuff over time

This needs to be reported in whatever components you have piling up stuff. Notifications should be withdrawn when they're outdated. They shouldn't pile up. If they're piling up, that's a bug and we should fix that bug rather than making a workaround

danirabbit avatar Nov 29 '25 00:11 danirabbit

This is not really true. People don't really turn off their devices anymore. So session end more likely means your battery died (in which case you really don't want to be deleting things) or you ran system updates

We turn ours ? We are people last i checked ?

Either way proposals for the same "clean after x days" have been ignored so it is pointless to even discuss

the DE is piling up stuff over time

This needs to be reported in whatever components you have piling up stuff. Notifications should be withdrawn when they're outdated. They shouldn't pile up. If they're piling up, that's a bug and we should fix that bug rather than making a workaround

Ive linked to several issues on eOS side, they are several years old, they are still open

And again, it is not reasonable to expect every apps to play nice and follow conventions, the DE should be there to moderate it

Again, else we wouldnt clear cache, have wayland to limit stuff, flatpak, portals

This is Nuh Uh territory, and it costs you goodwill each time. Just say it if you dont want anything done

teamcons avatar Nov 29 '25 09:11 teamcons