website icon indicating copy to clipboard operation
website copied to clipboard

Published 20 hours ago • verified publisher icon elementary

Upgrade Node

Open RMcNeely opened this issue 2 years ago • 4 comments

Problem

Currently, the website runs on Node 12 which hit end of life sometime around 2020 (it has actually scolled off of the releases page of Node's Github). This means that the version of node and npm are no longer receiving security fixes and improvements. We should switch to a newer supported version of Node and NPM with the project. As of the time of this issue the current LTS is Node 16 however it is scheduled to become the maintenance release before the end of the month.

Node release cycle: https://github.com/nodejs/release#release-schedule

Proposal

Adopt either Node 16 or Node 18.

RMcNeely avatar Oct 05 '22 01:10 RMcNeely

@RMcNeely please assign me this. I would like to take up the project

Belta-shazzar avatar Oct 05 '22 02:10 Belta-shazzar

I don't think you can assign issues but if you file a PR you can request a review and I'll try to prioritize it.

RMcNeely avatar Oct 05 '22 03:10 RMcNeely

I know that upgrading Node on the current server breaks everything, but it's an older release of Ubuntu LTS (16.04.7) so it might be a problem with that. If Node 18.x is going to be LTS we should probably try and move to that.

lewisgoddard avatar Oct 05 '22 12:10 lewisgoddard

Is the breakage a result of the way Node is installed on the server or just that there are issues compiling with newer releases? I have been building with Node 16 LTS locally but I haven't noticed any issues so far.

RMcNeely avatar Oct 05 '22 13:10 RMcNeely

It's probably intertwined with the outdated base and outdated node and npm all on that platform.

lewisgoddard avatar Oct 24 '22 15:10 lewisgoddard

Blocked by #3101

davidmhewitt avatar Nov 07 '22 10:11 davidmhewitt

This is now complete. We're running Node 18 on the server

davidmhewitt avatar Nov 13 '22 01:11 davidmhewitt