website icon indicating copy to clipboard operation
website copied to clipboard

Responsive nav bar

Open colinkiama opened this issue 2 years ago • 3 comments

Fixes #3056

Changes Summary

  • Adds hamburger menu at mobile breakpoints
  • Fully expanded menu shows by default when JavaScript is unavailable
  • Hamburger menu disappears and regular menu layout returns at a viewport width of 800px or higher.

This pull request is ready for review.

colinkiama avatar Sep 14 '22 00:09 colinkiama

Here are screenshots of the changes:

Hamburger menu closed Hamburger menu open Fully expanded menu on mobile when no JavaScript is available

colinkiama avatar Sep 14 '22 00:09 colinkiama

Did you have a formatter run on the files here? The PR shows a lot of miscellaneous file changes that seem to be unaffiliated with the rest of the changes (whitespace and "). Is it possible to revert those changes?

RMcNeely avatar Oct 03 '22 15:10 RMcNeely

Did you have a formatter run on the files here? The PR shows a lot of miscellaneous file changes that seem to be unaffiliated with the rest of the changes (whitespace and "). Is it possible to revert those changes?

Those unrelated files that have been updated are where I used the auto-fix commands of the linting tools for CSS and JavaScript in the project (stylelint and ESLint respectively).

Reverting these changes will cause the CI tests to fail during the lint check stages.

So unfortunately, no. It won't be possible to revert the changes.

colinkiama avatar Oct 03 '22 15:10 colinkiama

As requested, I've reverted the formatting changes. Only changes now are directly related to the issue this pull request solves

colinkiama avatar Jun 21 '23 17:06 colinkiama

Thanks Colin! This is a big improvement on what used to be there.

RMcNeely avatar Jun 27 '23 19:06 RMcNeely

Almost perfect, can you give the logomark a defined height of 48px so it matches the other items lineheight?

RMcNeely avatar Jun 27 '23 20:06 RMcNeely

Almost perfect, can you give the logomark a defined height of 48px so it matches the other items lineheight?

Unfortuantely setting the height or/and line-height of the logo causes misalignment issues:

Screenshot from 2023-06-27 22 40 12 Screenshot from 2023-06-27 22 39 58

I could try work around this by using setting the logomark as a flexbox. What do you think? Is it worth it?

colinkiama avatar Jun 27 '23 22:06 colinkiama

Never mind, I figured it out

colinkiama avatar Jun 27 '23 22:06 colinkiama