stylesheet icon indicating copy to clipboard operation
stylesheet copied to clipboard

Improve Notebook styling

Open jepotter1-archive opened this issue 4 years ago • 6 comments

With light theme:

notebook-files

With dark theme:

notebook-code

Works with notebooks of all orientations (top, bottom, left & right):

gtk-widget-factory-notebook

jepotter1-archive avatar Apr 04 '21 23:04 jepotter1-archive

Hmm... I'm going to have to think about the design of this a bit more.

@cassidyjames Design feedback/input needed.

jepotter1-archive avatar Apr 05 '21 03:04 jepotter1-archive

Okay, I've redesigned it to make it fit more with elementary's overall style, and also to improve on their sense of "physicality." The description has been updated to display the new style. I can further iterate based on feedback from the elementary team, if desired, but I will go ahead and mark this as "ready for review" since it looks good enough to me.

jepotter1-archive avatar Apr 05 '21 06:04 jepotter1-archive

I'm pretty sure this was an intentional change, and I feel that trying to rewrite something that was only recently done is not the right path. If you want to give connected tabs a shot I'd recommend on top of the sass Cassidy was experimenting with in this branch

hanaral avatar Apr 05 '21 22:04 hanaral

I'm pretty sure this was an intentional change, and I feel that trying to rewrite something that was only recently done is not the right path. If you want to give connected tabs a shot I'd recommend on top of the sass Cassidy was experimenting with in this branch

I tried that branch, but unfortunately it produces a bunch of weird visual artifacts and buginess when used with the latest master, so I thought it would be easier just to write it from scratch.

jepotter1-archive avatar Apr 06 '21 04:04 jepotter1-archive

I tried that branch, but unfortunately it produces a bunch of weird visual artifacts and buginess when used with latest master, so I thought it would be easier just to write it from scratch.

All you have to do is copy and paste the part that does the connected style on to the up to date sass.

hanaral avatar Apr 06 '21 07:04 hanaral

@jwinnie it looks like you're sort of recreating the notebook.inline-toolbar style which is nice but should be only used with an explicit style class. See #1024 for context.

cassidyjames avatar May 11 '21 22:05 cassidyjames