stylesheet icon indicating copy to clipboard operation
stylesheet copied to clipboard

Cannot be packaged as a flatpak due to theme name containing `.`

Open TingPing opened this issue 4 years ago • 4 comments

The current theme names are ID style (io.elementary.stylesheet.banana).

However the way Flatpak does themes is it uses extension points, and extension points match by . separators.

So org.gtk.Gtk3theme.theme-name means theme-name is an extension to org.gtk.Gtk3theme.

org.gtk.Gtk3theme.io.elementary.stylesheet.banana means banana is an extension to org.gtk.Gtk3theme.io.elementary.stylesheet which will fail and not be useful.

AFAICT you cannot explicitly set an extension point name separate from the ID but I might be missing something there.

Two potential paths forward:

  • ~~Change flatpak to support remaping another character to ., like _ or -. The downside here is that change will take a long time to make it to users.~~

  • Rename the theme upstream to be more accommodating.

TingPing avatar Aug 11 '21 17:08 TingPing

Note that we can't easily change the theme names now that OS 6 has been released; it would require changing several components that use the theme names as well as changing the user's current settings out from under them and that sounds like a huge potential for breakage. So at the earliest this could be fixed from our side for OS 7.

cassidyjames avatar Aug 11 '21 17:08 cassidyjames

And as a note, our recommendation to Flatpak app authors that have tested their apps against the elementary stylesheet and want it to be used on elementary OS is that they opt into using it by either using the elementary Platform (as required in the AppCenter remote) or by bundling the stylesheet (as I believe Epiphany does?).

cassidyjames avatar Aug 11 '21 17:08 cassidyjames

https://github.com/flatpak/flatpak/pull/4366

TingPing avatar Aug 11 '21 17:08 TingPing

This is a major "oops" that was easily avoidable

OssNass avatar Aug 12 '21 13:08 OssNass