store icon indicating copy to clipboard operation
store copied to clipboard

Setup stripe auto tax for checkout

Open btkostner opened this issue 4 years ago • 4 comments

This PR sets up Stripe taxes for checkout.

image

One regression, because the total is generated after we create the printful order, the total on printful's side will not be accurate. This can be remedied by dropping the stripe library we are currently using and rolling our own API client.

Also note, the tax that Stripe is giving us is less than what Printful was. For my address it comes out to $2.84 in stripe and $7.43 with Printful. I'm going to guess that's due to our origin address switching from what ever Printful uses to the one we have on file on Stripe.

And lastly, we will need to add registrations to start collecting taxes in areas: https://stripe.com/docs/tax/set-up

btkostner avatar Jul 13 '21 04:07 btkostner

Partially fixes #86 by having tax calculated after discount.

btkostner avatar Jul 13 '21 04:07 btkostner

Fixes #85 once registration is added for EU countries

btkostner avatar Jul 13 '21 04:07 btkostner

We need to figure out what warehouse printful will use to fulfill an order, and use that address as the shipping address from Stripe's side. This will give us a more accurate VAT and tax information.

btkostner avatar Aug 16 '21 19:08 btkostner

This is now a WIP PR. The scope has expanded to include:

  • the shipping selector in stripe checkout
  • no longer having to draft orders and cancel them later on. They are created after payment is made
  • async payment methods will now work
  • discount codes apply correctly

TODO:

  • VAT is not being calculated for addresses. Need to talk to Stripe about this.

btkostner avatar Nov 18 '21 04:11 btkostner