screenshot icon indicating copy to clipboard operation
screenshot copied to clipboard

Replace FileChooserButton for GTK4

Open treppenwitz03 opened this issue 2 years ago • 8 comments

This hopes to check a todo in https://github.com/elementary/screenshot/pull/240 so screenshot can be ported.

treppenwitz03 avatar Feb 09 '22 09:02 treppenwitz03

Maybe should stick to the FileChooserNative API as this is now Flatpak'd?

jeremypw avatar Feb 14 '22 11:02 jeremypw

Right! I agree. Thanks @jeremypw

treppenwitz03 avatar Feb 14 '22 13:02 treppenwitz03

Screenshot from 2022-05-31 18 03 40

The drop arrows on the two buttons are of a different size, furthermore the filechooser button does not produce a dropdown when clicked, but a dialog so I think it should have an ellipsis?

jeremypw avatar May 31 '22 17:05 jeremypw

Screenshot from 2022-05-31 18 44 31

This is how it looks after applying my suggestions (I also increased the icon size to 24px but that is not essential).

jeremypw avatar May 31 '22 17:05 jeremypw

@jeremypw is there an icon we can use for ellipsis? Thank you.

treppenwitz03 avatar Jun 01 '22 04:06 treppenwitz03

oh I found it! it is content-loading-symbolic

treppenwitz03 avatar Jun 01 '22 04:06 treppenwitz03

Screenshot from 2022-06-01 04 30 48

it does not seem aligned still.

treppenwitz03 avatar Jun 01 '22 04:06 treppenwitz03

Probably best seek @danrabbit 's opinion on the finer points of the design.

jeremypw avatar Jun 01 '22 14:06 jeremypw

Still being held up by the existence of #253.

jeremypw avatar Jul 21 '23 11:07 jeremypw