mail icon indicating copy to clipboard operation
mail copied to clipboard

Tapping Esc when drafting a mail doesn't save the draft

Open cassidyjames opened this issue 7 years ago • 8 comments

As far as I can tell, hitting the close button on the window saves the draft, but hitting the escape key does not. I just accidentally lost a big long draft. :cry:

cassidyjames avatar Sep 18 '18 19:09 cassidyjames

If you ware talking about the 0.4 Loki, then it doesnt save the draft at all

atirut-w avatar Sep 26 '18 05:09 atirut-w

As far as I can tell, in the mail rewrite drafts are never saved

danirabbit avatar Feb 14 '19 04:02 danirabbit

So what is the design we want for drafts? It sounds like we want auto-save on close, but should it be auto-saving regularly all the time? Or do we want a Save action in the UI?

vertexian avatar Jun 02 '19 17:06 vertexian

@vertexian following the elementary HIG would imply autosaving at least on close, if not at regular intervals/when things change (like Code). I don't think we'd want/need an actual save action in the UI.

cassidyjames avatar Jun 26 '19 01:06 cassidyjames

This seems to be current behaviour, at least on 5.1 Hera.

getsnoopy avatar Jan 08 '20 04:01 getsnoopy

I can confirm this behavior on 5.1 Hera. Just lost a rather complicated draft because I accidentally hit ESC and now I can't seem to find it anywhere. [rantmode] Honestly, I don't understand how one can come up with this behavior in the first place, seriously considering switching back to Thunderbird or Evolution right now...[/rantmode]

Bounty upped to $30. Is there anything else one can do to speed up fixing this? It's a deal-breaker for me, and I otherwise rather like this application.

ramonziai avatar Jan 24 '20 13:01 ramonziai

Just had a look at the code (I've never written a line of Vala in my life, but it seems similar enough to Java). There doesn't seem to be a method for saving drafts at all, unless I missed something. If so, this seems to be a bigger change. How about meanwhile introducing a little confirmation dialog whenever people hit ESC or the "Discard Draft" button? Code also asks for confirmation if you attempt to close a new unnamed file, so that shouldn't conflict with the HIG.

Also, how about hiding "Drafts" from the folder view until there's an established way of actually putting something there?

ramonziai avatar Jan 24 '20 14:01 ramonziai

Draft saving when closing the composer is now implemented, however we don't currently close the compose window when pressing the escape key. So I'm going to leave this issue open for that, but bumping from milestones since the critical issue of saving drafts has been fixed

danirabbit avatar Jul 13 '21 20:07 danirabbit