elementary
Draft: check ESP size in bytes not sectors
Partially a necessary fix for #448 and #644. Also a continuation of PR #621 which mostly does not apply anymore four years later except for the ESP check.
So far this patch merely fixes the ESP partition size check triggered in the PartitionView when doing a custom installation with custom partitioning.
I am marking this as a draft as I was unable to build this patch so far. That is in progress.
@vjr would you be able to review this? :)
The diff LGTM but would be nice if someone can re-test , and if the following note might help: https://github.com/elementary/installer/pull/621#issuecomment-950168784
edit: the workflows builds seem to be failing with an "unused var" error too.
The diff LGTM but would be nice if someone can re-test , and if the following note might help: #621 (comment)
edit: the workflows builds seem to be failing with an "unused var" error too.
Oh neat that is indeed helpful. Did you set up a build environment within that VM or is there a reasonable well to set up a dev env on a non-ElementaryOS system? Building in a VM is probably easier for me.