houston icon indicating copy to clipboard operation
houston copied to clipboard

Require "provides" in AppStream data

Open cassidyjames opened this issue 5 years ago • 8 comments

It looks like this might be preventing https://github.com/bartzaalberg/recipes/ from showing up in AppCenter?

cassidyjames avatar Jan 27 '19 20:01 cassidyjames

It looks like this (probably?) isn't why it's not showing up; other apps also lack it and show up fine. Regardless, if it's best practice, we should still at least warn on its absence.

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-provides

cassidyjames avatar Jan 27 '19 21:01 cassidyjames

I can confirm it's not the issue in Recipes. Provides tag has been added and released but it's still not shown in AppCenter.

unbelievableflavour avatar Feb 12 '19 07:02 unbelievableflavour

https://appstream.elementary.io/appcenter/html/bionic/main/issues/com.github.bartzaalberg.recipes.html

I'll look into it when I get time

btkostner avatar Feb 12 '19 13:02 btkostner

Sorry, guys I think I found the error. Until now i didn't notice the .svg error in the link @btkostner send. I checked the files locally and they are also broken here so it's my problem. I will create a new icon and repush the app. That should probably fix it. When it works I will close this issue.

It's still is weird though that Houston build succeeds, there should probably be a check for that.

unbelievableflavour avatar Mar 04 '19 08:03 unbelievableflavour

@bartzaalberg Houston just checks if the file exists. It does no svg or xml parsing to ensure the file is an image, valid, or even if it has data.

btkostner avatar Mar 04 '19 16:03 btkostner

Ah ok. Well I added a new icon. Let's hope this fixes things.

unbelievableflavour avatar Mar 04 '19 16:03 unbelievableflavour

This fixed my issue. Should the ticket stay open or can it be closed?

unbelievableflavour avatar Mar 05 '19 17:03 unbelievableflavour

@bartzaalberg Keep it open. It's useful to have this as a test in houston.

btkostner avatar Mar 05 '19 18:03 btkostner