houston icon indicating copy to clipboard operation
houston copied to clipboard

Published 20 hours ago • verified publisher icon elementary

Issue #624: Add support for GitLab

Open rupertdev opened this issue 6 years ago • 14 comments

#624

  • added GitLab service
  • added tests

rupertdev avatar Jun 10 '18 04:06 rupertdev

@btkostner I may need a little help testing this tomorrow

rupertdev avatar Jun 10 '18 04:06 rupertdev

The tests are not failling right now. This is a bug with jest. I'm assuming because it modifies low level node code for module caching.

Ava recently added support for typescript, so I am currently working on a branch to move our tests over. This should fix all of these weird breaking test issues.

btkostner avatar Jun 10 '18 05:06 btkostner

Starting Houston as per the guide doesn't work for me at the moment, I can get the CLI to work, but not sure how to start Houston. The readme says to use node ./dest/cli/houston.js which I suspect is incorrect as that file doesn't exist

rupertdev avatar Jun 10 '18 11:06 rupertdev

You should be able to run npm start and get the cli interface. The web interface and such does not exist in V2 yet.

btkostner avatar Jun 10 '18 15:06 btkostner

Ready for review @btkostner

rupertdev avatar Jun 11 '18 21:06 rupertdev

Yep! Thanks for the PR! Just an FYI, it will probably be a while until I get to review this.

btkostner avatar Jun 11 '18 22:06 btkostner

Hey @btkostner, any idea when you'll be able to get to this?

rupertdev avatar Jun 29 '18 00:06 rupertdev

@rupertdev I'm currently working on merging v2 worker into master so devs can build for Juno. After that, I'll take a look at this. Sorry for the delay.

btkostner avatar Jun 29 '18 00:06 btkostner

My bad. I merged v2-publishing into v2 which closed this PR. Reopening.

btkostner avatar Jun 29 '18 03:06 btkostner

Woops. Keep deleting this branch.

btkostner avatar Jul 11 '18 01:07 btkostner

@btkostner Let me know when you're ready for this and I'll fix the merge conflicts

rupertdev avatar Jul 25 '18 19:07 rupertdev

Any update on this @btkostner ?

rupertdev avatar Sep 24 '18 13:09 rupertdev

@rupertdev Sorry. I honestly forgot about this PR. Good news though. Master has been updated so the class gets resolved by the IoC container, so it can use the app configuration and what not. I'll work on fixing the conflicts and updating the class as needed when I get some down time this week.

btkostner avatar Sep 24 '18 15:09 btkostner

@btkostner

  1. When will it be possible for me to get involved in app development for elementary OS via GitLab?
  2. And do you think it's also a good idea to support other services as well? E.g. I read about Codeberg recently, which is based on Gitea and wants to be a free European alternative to GitHub? The registered association behind Codeberg is based in Berlin, Germany. For more please check out https://blog.codeberg.org/codebergorg-launched.html or https://codeberg.org/

4jNsY6fCVqZv avatar Jan 26 '19 12:01 4jNsY6fCVqZv