OARS Verification

[fabianthoma]

Add a check for OARS Data, maybe as a warning first, enforce it beeing there later. https://hughsie.github.io/oars/index.html

[fabianthoma]

Also see elementary/appcenter#34

[Lewiscowles1986]

I've written to the author of the site linked above, who pointed me to https://github.com/hughsie/appstream-glib for validation works

Hi Lewis,

On 9 February 2018 at 08:01, --redacted-- wrote:
> Are you open to, or aware of any efforts to validate OARS?

I suppose appstream-glib should do a better job of validating the
contents; at the moment it just checks the XML is valid for a content
rating.

> Are you open to, or aware of any efforts to generate or work with OARS in a
> library?

appstream-glib is probably the thing to fix; it already parses oars
and operates on it (e.g. it does the age calculation for
gnome-software) so ideas (and patches?) welcome fr that 

--redacted--

I get this is JS. I'll take a look at what appstream/glib is doing. It'd be nice to have some level of API compatibility, even if separately implemented

Update

https://github.com/hughsie/appstream-glib/search?utf8=%E2%9C%93&q=OARS&type=

Looks like there is very little by way of content specific to OARS

[babluboy]

@btkostner Hi..I added the OARS data to the bookworm Appstream, but strangely the Houston CI travis script is failing for loki while succeeding for juno. Is this an issue with the script.

Error while running build for https://github.com/babluboy/bookworm for 0.0.1
================================================================================
  AppCenter was unable to find OARS `content_rating` tags. Please ensure that you
  add these to your AppStream file and release again.

[btkostner]

@babluboy If it fails on one dist and succeeds on another, it's probably because there is a different branch it's using for building. In this case, you have a loki branch that is being used for building loki, but it does not have an updated appstream file.

[btkostner]

Also, closing issue as this is implemented in houston worker v2

[babluboy]

@btkostner Many thanks for the pointer. Didn't realize Houston looks into branches other than master (Guessing the issue was that the branch was named loki). Have deleted the loki branch and now the build on Travis is all fine. Thanks.

[btkostner]

@babluboy right now for publishing it does not, but the next version (houston v2, currently available with that travis script) will use different branches for packaging and versioning.

[cassidyjames]

If this should be a new issue, I can file it there. But it appears we're not actually checking for the presence of OARS data afaict, but only validating it if it exists. However, we now require it for all apps in AppCenter and should treat it like any other required component, where we fail without it and file issues with links to documentation.

[cassidyjames]

This was removed in https://github.com/elementary/houston/commit/3815f42dcd4e022bdf6d7520b0194998d00d3fa3 to fix https://github.com/elementary/houston/issues/641, but it looks like we should have a different fix so that OARS data is actually required to be present.