houston icon indicating copy to clipboard operation
houston copied to clipboard

Build HiDPI icons components for Dep11

Open danirabbit opened this issue 6 years ago • 8 comments

Looking at Our Dep11 components it seems that we only build packages for icons-64x64 and icons-128x128.

If possible, we should:

  • [x] Build 64px@2 icons
  • [x] Build 128px@2 icons
  • [ ] Build 48px and 48px@2 icons

It looks like we already ship a config file that wants to pull the 64px@2 package and I've filed an issue against elementary/os to look for the 128px@2 icons.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

danirabbit avatar Sep 15 '17 20:09 danirabbit

Looks like the HiDPI for asgen was recently merged, and not released yet. We will want to wait for a GitHub release so we can build it on our server.

https://github.com/ximion/appstream-generator/pull/48

btkostner avatar Sep 15 '17 21:09 btkostner

@btkostner The feature has been released with version 0.6.6

Appeltabak avatar Sep 27 '17 19:09 Appeltabak

@danrabbit as far as I know, there is no configuration to enable 48px icons.

EDIT It's hard set in appstream-generator here: https://github.com/ximion/appstream-generator/blob/master/src/asgen/handlers/iconhandler.d#L55

btkostner avatar Oct 05 '17 06:10 btkostner

Opened a new issue here: https://github.com/ximion/appstream-generator/issues/56

danirabbit avatar Oct 26 '17 02:10 danirabbit

Since that issue seems stalled, shall we carry a patch to asgen that generates 48 and 48@2 icons?

cassidyjames avatar Oct 26 '17 20:10 cassidyjames

@cassidyjames I'm not sure if that would also require a patch to libappstream. Probably better to wait a little bit and see if we can't discuss it more with Matthias

danirabbit avatar Oct 27 '17 00:10 danirabbit

What's the current status of this issue?

jtrees avatar Feb 15 '18 10:02 jtrees

Stalled and waiting for upstream movement

btkostner avatar Feb 15 '18 14:02 btkostner