houston icon indicating copy to clipboard operation
houston copied to clipboard

Make private repo access requirement optional

Open rolandixor opened this issue 7 years ago • 3 comments

What it says on the tin.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

rolandixor avatar May 16 '17 19:05 rolandixor

Is there a need to read private repos?

Would this be as easy as changing the scope to 'public_repo read:org' at:

https://github.com/elementary/houston/blob/489557c60e9ee7cb123d953c2e43e3843acd4ec2/src/houston/passport/github.js#L136

dbhowell avatar Nov 02 '17 09:11 dbhowell

The problem with just changing the scope is that then if someone has a private repo they are releasing, it will break permissions.

I think going ahead, we would need to store a bool in the database if the user has private repos enabled or not and change the scope dynamically based on that.

btkostner avatar Nov 02 '17 15:11 btkostner

That makes sense, I just assumed that the repo had to be public.

dbhowell avatar Nov 05 '17 22:11 dbhowell