greeter icon indicating copy to clipboard operation
greeter copied to clipboard

Published 20 hours ago • verified publisher icon elementary

Support dark mode

Open lenemter opened this issue 2 years ago • 9 comments

Fixes https://github.com/elementary/greeter/issues/688 Closes #563 Closes #499

To do:

  • [x] Deduplicate objects
  • [x] More testing

lenemter avatar Sep 02 '23 10:09 lenemter

Close my commit well

BAProductions avatar Sep 02 '23 13:09 BAProductions

Testing this with the latest settings-daemon, I am now getting a blank screen on the greeter :grimacing: Does this need to be updated too?

danirabbit avatar Jan 31 '24 00:01 danirabbit

That's weird. Have you installed https://github.com/elementary/wingpanel/pull/499 by any chance? If you have, try uninstalling it.

lenemter avatar Jan 31 '24 00:01 lenemter

I fixed a bug that prevented setting user preferences, everything should work as expected now.

lenemter avatar Feb 03 '24 10:02 lenemter

Sorry for taking a while to respond! Just tried again on a relatively clean OS 8 install where I have not had that wingpanel branch and I'm still getting a blank/gray screen with this branch. So it seems like the compositor is probably loading but not the panel or greeter window

danirabbit avatar Feb 05 '24 17:02 danirabbit

@danirabbit Not sure what might have caused that. Can you send me logs from /var/log/lightdm/seat0-greeter.log please?

lenemter avatar Feb 08 '24 05:02 lenemter

@lenemter sorry for taking a while to follow up!

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.863: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.863: g_settings_set_value: key 'document-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.865: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.865: g_settings_set_value: key 'font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.866: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.866: g_settings_set_value: key 'monospace-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_unref: assertion 'value != NULL' failed

** (io.elementary.greeter:39487): CRITICAL **: 10:02:05.879: MainWindow.vala:350: prompt: `Password: ' (1)

** (io.elementary.greeter:39487): CRITICAL **: 10:02:06.698: MainWindow.vala:350: prompt: `Password: ' (1)

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.364: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.364: g_settings_set_value: key 'document-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.367: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.367: g_settings_set_value: key 'font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.369: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.369: g_settings_set_value: key 'monospace-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_unref: assertion 'value != NULL' failed

** (io.elementary.greeter:39487): CRITICAL **: 10:02:07.379: MainWindow.vala:350: prompt: `Password: ' (1)

** (io.elementary.greeter:39487): CRITICAL **: 10:02:08.084: MainWindow.vala:350: prompt: `Password: ' (1)

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.866: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.866: g_settings_set_value: key 'document-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.868: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.868: g_settings_set_value: key 'font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.878: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.878: g_settings_set_value: key 'monospace-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_unref: assertion 'value != NULL' failed

** (io.elementary.greeter:39487): CRITICAL **: 10:02:08.886: MainWindow.vala:350: prompt: `Password: ' (1)

** (io.elementary.greeter:39487): CRITICAL **: 10:02:09.767: MainWindow.vala:350: prompt: `Password: ' (1)

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.550: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.550: g_settings_set_value: key 'document-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.551: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.552: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.552: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.552: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.552: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.552: g_settings_set_value: key 'font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.552: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.553: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.553: g_settings_set_value: key 'monospace-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_unref: assertion 'value != NULL' failed

danirabbit avatar Feb 13 '24 18:02 danirabbit

@lenemter There is a conflict to resolve now

zeebok avatar May 23 '24 15:05 zeebok

I am seeing the same compiler errors as the checks

zeebok avatar Jun 24 '24 14:06 zeebok