granite icon indicating copy to clipboard operation
granite copied to clipboard
verified publisher icon elementary

Styles: Add Granite.CssClass.TERMINAL

Open wpkelso opened this issue 8 months ago • 3 comments

  • Deprecate Granite.STYLE_CLASS_TERMINAL
  • Add Granite.CssClass.TERMINAL
  • Add super basic styling for class

image

wpkelso avatar May 13 '25 18:05 wpkelso

Open question: Might this be better used as an internal style to a new TerminalView widget? Every time this is used in our repos, it's in the context of a ScrollBox with a TextView child.

wpkelso avatar May 14 '25 01:05 wpkelso

Yeah I actually wonder if we should have this public facing at all. Because we mainly use it in messagedialog. The sideload and installer cases I think I'd be okay with them using undocumented API or just supplying their own styles. I'm not sure this style is actually useful outside of system apps since everyone else is expected to use MessageDialog

danirabbit avatar May 14 '25 16:05 danirabbit

I'm happy with the style class being undocumented or internal. I think it's still worth it to abstract all of it into a widget, as even in the system apps and widgets the use cases for a terminal view are so similar that it should make the code cleaner. I've started another branch off this one to play around with that idea in #867

wpkelso avatar May 14 '25 16:05 wpkelso