files icon indicating copy to clipboard operation
files copied to clipboard

Visual reordering when opening large folders in list mode

Open peteruithoven opened this issue 3 years ago • 5 comments
trafficstars

What Happened?

There might be some overlap with the following issue but my symptom seems a bit different.

  • https://github.com/elementary/files/issues/1939
  • https://github.com/elementary/files/issues/1794

I see Files visually rearranging files in the list or column mode. It does not seem to matter whether I sort files on name or modified. In general it seems to take many times longer to open folders in Files than in the file chooser.

List

Screen record from 2022-01-25 22 52 19 list mode

Columns

Screen record from 2022-01-25 22 55 10 columns

Grid

In grid mode it also takes long, but no visual re-ordering Screen record from 2022-01-25 22 54 01 grid

Native file chooser

Also notice how opening the same folder in the native file chooser takes no time at all Screen record from 2022-01-25 22 59 21 file chooser

Steps to Reproduce

  1. Open Files
  2. Go to a folder with lot's of files

Expected Behavior

It takes a bit longer, but not 6 seconds while seeing files being re-arranged.

OS Version

6.x (Odin)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

OS: elementary OS 6.1 Jólnir x86_64 Host: XPS 15 9550 Kernel: 5.13.0-27-generic Uptime: 5 hours, 9 mins Packages: 2099 (dpkg), 90 (flatpak) Shell: bash 5.0.17 Resolution: 3840x2160, 3840x2160 DE: Pantheon WM: Mutter(Gala) Theme: io.elementary.stylesheet.blueberry [GTK3] Icons: elementary [GTK3] Terminal: io.elementary.t CPU: Intel i7-6700HQ (8) @ 3.500GHz GPU: NVIDIA GeForce GTX 960M GPU: Intel HD Graphics 530 Memory: 15949MiB / 31924MiB

peteruithoven avatar Jan 25 '22 22:01 peteruithoven

I have done some work on improving load speed relating issues (see #1953) although that needs some more work in fixing failing unit tests (it should still be usable). I'll try and get that in a reviewable state.

jeremypw avatar Jan 26 '22 17:01 jeremypw

The above mentioned PR loads all the files before sorting so should fix this issue.

jeremypw avatar Jan 26 '22 17:01 jeremypw

The native file chooser uses the Gtk file view which loads less info about each file object. The above mentioned PR also tries not to load any more file info than needed initially and loads it on demand instead.

jeremypw avatar Jan 26 '22 17:01 jeremypw

Ow whow, that PR seems great! I'm happy to close this issue or you could add it to the Fixes list in the PR.

peteruithoven avatar Jan 26 '22 18:01 peteruithoven

We might as well keep it open as it is slightly different from the others.

jeremypw avatar Jan 27 '22 09:01 jeremypw

This seems fixed :tada:

peteruithoven avatar Oct 04 '23 11:10 peteruithoven