files icon indicating copy to clipboard operation
files copied to clipboard

Double click option

Open jeremypw opened this issue 3 years ago • 3 comments

Fixes #1960

Providing this option only requires relatively trivial changes to the click handling code. Most of the diff is providing the UX to change the option the remember it state.

For simplicity the option accompanies other similar settings toggles in the view context menu, although it would be perhaps better placed in an AppMenu.

It is not necessary to install the PR to test the UX and functionality but in that case the setting will not be persisted.

jeremypw avatar Jan 10 '22 18:01 jeremypw

Any possibility to have this at least reviewed before OS 7?

ibrahimrahman avatar May 05 '22 13:05 ibrahimrahman

@JoseExposito Thanks for the review! What was the conflict with master you mentioned? Github is not showing anything. I'll not merge this before more comment as it is likely to be controversial.

jeremypw avatar Aug 09 '22 08:08 jeremypw

@jeremypw I got a conflict rebasing on top of master, but it looks like it was on my end, GitHub didn't have any issues merging master into you branch.

I'll not merge this before more comment as it is likely to be controversial.

Agrees. I truly think that it is great to provide this option, but it could be controversial.

JoseExposito avatar Aug 13 '22 10:08 JoseExposito

I think if it is an option, I see no issue with it being added. For me the vision of the project should be the defaults, not always the only way. Particularly something like this that can really mess with people's workflow.

zeebok avatar Aug 20 '22 03:08 zeebok