Ask for confirmation when renaming a file/folder from within its properties

[ibrahimrahman]

Problem

At the moment there's no obvious way to cancel renaming from within the properties view. This means that (for eg.) a mis-click will rename the file/folder with no way of reverting it. Or if the user changes their mind while renaming the item, they must manually re-enter the original name which may be too long or complicated. To revert this they can first close the properties view and press ctrl+z but this isn't obvious to the user and is problematic when a file is renamed by mistake.

I personally have mistakenly pressed the ` key under Esc while closing the properties view and renamed a folder without realizing it.

Proposal

Use an apply button to save changes instead of automatically saving them

[jeremypw]

I am not sure about another button - need UX team opinion on that, but you are right that "Esc" should not apply any name change - it should act like it does when renaming from the context menu. Perhaps when the name has been changed, the "Close" button can be relabelled to "Rename" - but then I guess we would need to have a "Cancel" button as well?

[ibrahimrahman]

I'm for adding a second button since the bottom of the properties view isn't busy enough for it to become cluttered. Apply would still make more sense than Rename since that can be used to apply changes to default launch application and permissions (which can be troublesome if changed mistakenly)

If this is the route that's taken, I guess it would make sense to change close to cancel since close doesn't explicitly clarify if changes are reverted or not

[jeremypw]

Yes, makes sense.