8.1.0 fails to build with GCC 14 (-Wint-conversion)

[bobby285271]

What Happened?

As the title says, the build FTBFS for me on NixOS with:

src/io.elementary.dock.p/WindowSystem/WindowSystem.c: In function 'dock_window_system_find_window':
src/io.elementary.dock.p/WindowSystem/WindowSystem.c:577:60: error: passing argument 2 of 'g_ptr_array_find_with_equal_func' makes pointer from integer without a cast [-Wint-conversion]
  577 |         _tmp2_ = g_ptr_array_find_with_equal_func (_tmp0_, uid, ___lambda7__gequal_func, &_tmp1_);
      |                                                            ^~~
      |                                                            |
      |                                                            guint64 {aka long unsigned int}

Full build log: build.log (the build log is built with Vala 0.56.17, I also tried latest Vala 0.56.18 and the failure is the same).

8.1.0 builds fine for me with GCC 13, and 8.0.2 builds fine for me with GCC 14 💦

We are temporarily working around the issue with -Wno-error=int-conversion.

Steps to Reproduce

1. Build with GCC 14

Expected Behavior

Builds.

OS Version

NixOS unstable

Session Type

Classic Session (X11, This is the default)

Software Version

Latest release (I have run all updates)

Log Output

build.log

Hardware Info

No response