code icon indicating copy to clipboard operation
code copied to clipboard

Line numbers in high contrast theme

Open patx opened this issue 7 years ago • 4 comments

The line numbers have the same white background as the rest of my text (white). It makes it very confusing to look at code that is not indented. The two other themes do not have this issue as they both have a grey pellucid background behind the lines numbers. I think the same should be done for the high contrast theme. I like my white background but you need separation between the line numbers and the text.

patx avatar Oct 24 '18 17:10 patx

There seems to be a full-white line between the numbers and the text where as the background of the numbers and text is slightly off-white. Not easy to see though. A high-contrast solution might be to draw the line in mid-grey. Not sure atm what needs to be changed to do this or conversely to adjust the line number background.

jeremypw avatar Jun 18 '25 17:06 jeremypw

@jeremypw Yes that would be good. I see in the code that the other two themes have their own stylesheets but the high contrast theme acts differently. See here. I think we should have a stylesheet for the high contrast theme as well.

Thoughts on this @danirabbit ?

patx avatar Jun 19 '25 02:06 patx

@patx I have experimented with a modified elementary-light theme to make it higher contrast (see #1602). Here is how it looks so far:

Image

jeremypw avatar Jun 19 '25 14:06 jeremypw

@jeremypw this looks pretty good. I think a grey background for the numbers looks more modern with the white main background. I also assume elemenatry wants to keep their current light theme as-is. We need to create a new XML style sheet for the high contrast/white theme.

patx avatar Jun 22 '25 15:06 patx