code icon indicating copy to clipboard operation
code copied to clipboard

Add custom elementary syntax styles

Open micahilbery opened this issue 3 years ago • 9 comments

This adds custom styles for syntax highlighting based on the elementary color palette.

fixes #29

micahilbery avatar Jul 01 '21 02:07 micahilbery

@micahilbery is this supposed to fix the long-standing issue of the highlight cursor colour in the solarised theme being the same?

hanaral avatar Jul 01 '21 07:07 hanaral

@hanaral If you're talking about the bracket highlighting and selection highlighting being the same then yes this fixes that. selection-vs-bracket-highlighting

micahilbery avatar Jul 01 '21 14:07 micahilbery

If you're talking about the bracket highlighting and selection highlighting being the same then yes this fixes that.

It looks like that the selection style is applied in preference to the bracket-match style so brackets that are both matching and selected only get the selection style. Presumably this behaviour is controlled by gtksourceview-4.

jeremypw avatar Jul 05 '21 18:07 jeremypw

@micahilbery Will you be addressing the issue with gutter colors?

jeremypw avatar Nov 03 '21 09:11 jeremypw

Yes, I hope to work on it today. Sorry for the delay. My day job and seasonal plans have pretty well wiped out my free time.

micahilbery avatar Nov 03 '21 11:11 micahilbery

I've updated the style so that we match classic and tested the git gutters. Afaict everything seems to be working as it should. Sorry this took me so long to get to.

micahilbery avatar Nov 10 '21 16:11 micahilbery

Thanks - I'll try these out for a while to see if any issues arise.

jeremypw avatar Nov 10 '21 16:11 jeremypw

I've merged this PR into my 'merge-dev-fixes- branch for dog-fooding.

Do far I've noticed that it is harder to see the selected text, especially for solarized-light:

ElementarySolarizedLightSelectedText

ElementarySolarizedDarkSelectedText

However, it is easier to distinguish selected brackets from highlighted brackets.

Is there a reason why selected text in the dark version is inverted in color whereas in the light version it isn't?

jeremypw avatar Nov 10 '21 17:11 jeremypw

I can confirm that the gutter colors are now working.

jeremypw avatar Nov 10 '21 17:11 jeremypw

@micahilbery I'm inclined to merge this as @danirabbit is :+1: Just one question: "Follow System Style" uses the standard "solarized-light" and "solarized-dark" styles - is that intended?

jeremypw avatar Oct 21 '22 10:10 jeremypw