calendar icon indicating copy to clipboard operation
calendar copied to clipboard

Clickable links in event descriptions

Open igordsm opened this issue 4 years ago • 4 comments

Fix #571 . Implementation was based on this mailing list message. Requests for improvements are welcome.

calendar-link-2

igordsm avatar Mar 07 '21 20:03 igordsm

Thanks for the PR! It seems to work as advertised for me. I haven't taken a very close look at the code, but in the meantime there are a few features that could use some work here:

  1. The formatting of the link should follow the system theme. I'm not sure how to get this to work in a TextView, but it should use the current accent color and look good in both dark and light modes. @elementary/ux do we want to use the system accent color for links like this or do we want to use the green accent that we use elsewhere in Calendar?
  2. There should be some sort of tooltip to indicate that links are clickable. Include something like "Hold ctrl and click to follow link" (the copy could use some work, of course).

mcclurgm avatar May 28 '21 20:05 mcclurgm

I'm gonna convert this back to draft since there hasn't been any movement in the last couple weeks. Feel free to mark ready for review once requested changes have been made :)

danirabbit avatar Jun 15 '21 19:06 danirabbit

I'm waiting on the granite update to proceed. As soon as it lands I'll get back to this.

igordsm avatar Aug 09 '21 19:08 igordsm