Event dialog asks for location permission every time it's opened

[mcclurgm]

Prerequisites

• [x] I have searched open and closed issues for duplicates.

Describe the bug

When location permission is disabled in privacy settings, the event dialog throws up a dialog asking for permission every time it's opened.

To Reproduce

Steps to reproduce the behavior:

1. In privacy settings, turn off location services. This can be either completely, or just for Calendar.
2. Open Calendar click the new event button.
3. The event dialog opens, and a permission dialog immediately follows.

You can do these steps any number of times and the permission dialog will appear.

Expected behavior

Calendar should ask for this permission once, then not send this dialog again. If we want to keep asking for permission, it should be in the UI of the dialog somewhere. Nagging the user every time they edit an event is not a good experience.

Logs

n/a

Platform Information

• [x] I'm using the latest version from git that I've manually compiled
• [ ] I'm using the latest released stable version

Additional context

n/a

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[fabiozaramella]

I can't reproduce this issue. Does it still happen to you?

[mcclurgm]

Every time (on Hera fwiw). Do you have location permission disabled for calendar?

[fabiozaramella]

Yes, it's disabled but I'm on Odin daily so that may be the reason then.

[4jNsY6fCVqZv]

Exciting, first I asked myself how the issue could be reproduced. Tracking services are basically switched off for me. This leads me to this issue https://github.com/elementary/calendar/issues/540 To be able to reproduce your issue, I first have to activate the Location Services in the Security & Privacy Plug. Then open Calendar, click the new event button and select Deny. So I suspect that a system which has deactivated the Location Services from the beginning cannot reproduce the issue.

Another thing I noticed, once there is an entry of Calendar in the Location Services section in Security & Privacy Plug, I can't delete it from the list anymore. I can only deactivate or activate it. When I deactivate the Location Services again, Calendar disappears from the list. As soon as I reactivate the services, the Calendar entry is back. Is this intended?