calendar icon indicating copy to clipboard operation
calendar copied to clipboard

RDNN package name

Open cassidyjames opened this issue 4 years ago • 8 comments

Looks like #85 took care of everything else, but we still have maya-calendar as the package name here.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

cassidyjames avatar Jun 30 '20 17:06 cassidyjames

Where exactly in the code do changes to the package name have to be made?

By the way: Is there a reason why the maya.gresource.xml still exists under this name? Or can I rename it safely?

4jNsY6fCVqZv avatar Jun 30 '20 17:06 4jNsY6fCVqZv

@4jNsY6fCVqZv I think packaging changes need to be made in the deb-packaging branch, but we'd need to make sure it is not going out to Hera users—which will require coordination with @danrabbit and/or @tintou.

That file should be able to be renamed as long as any code referencing it (i.e. in meson) is also updated—but it would be a separate branch from any packaging changes.

cassidyjames avatar Jun 30 '20 21:06 cassidyjames

@cassidyjames Will Daemon be enough at io.elementary.calendar-daemon.desktop.in? Or should there be a linguistic reference to the calendar? Currently it's still Maya Daemon. I wonder if it is important to replace all the Maya references bit by bit. What are your thoughts on this as a team?

@danrabbit @tintou Could you imagine to teach me how to make this transition?

4jNsY6fCVqZv avatar Jun 30 '20 23:06 4jNsY6fCVqZv

@4jNsY6fCVqZv several small branches are always going to be easier to review and merge :)

The name field for the daemon .desktop shouldn't actually show anywhere, so it should be fine to rename it to anything really. But in that case that it somehow does show somewhere, I think "Calendar Daemon" would be most appropriate

I created a deb-packaging-bionic branch to make sure we don't interfere with bionic builds unintentionally.

If you look at Camera, you see how there are transitional packages defined here: https://github.com/elementary/camera/blob/deb-packaging/debian/control#L21

So that needs to be done for every package that calendar provides

danirabbit avatar Jun 30 '20 23:06 danirabbit

Here's a much simpler example. I'm not 100% certain, but I think this should do it: https://github.com/elementary/greeter/pull/448/files

danirabbit avatar Jun 30 '20 23:06 danirabbit

@danrabbit Thanks a lot for the hints!

I see the following packages: maya-calendar, maya-calendar-common, maya-calendar-daemon, libmaya-calendar0, libmaya-calendar-dev, maya-calendar-plugin-google, maya-calendar-plugin-caldav.

  1. Is it really necessary to keep all the (transitional) packages? Or can debian/control be cleaned up a bit here?
  2. Is it just a matter of changing the packages in debian/control, or do I need to make appropriate changes for all maya-calendar called files here as well? https://github.com/elementary/calendar/tree/deb-packaging/debian

4jNsY6fCVqZv avatar Jul 04 '20 16:07 4jNsY6fCVqZv

I still want to work on a solution. Are there people who can support me in clarifying my open questions?

4jNsY6fCVqZv avatar Oct 09 '20 14:10 4jNsY6fCVqZv

@4jNsY6fCVqZv I think @tintou might answer you questions

fabiozaramella avatar Oct 16 '20 10:10 fabiozaramella