App: cache menu model, wait to init pinned action
There's likely a race here that makes the applications menu unpin items if the dock isn't loaded yet
I don't think this PR addresses the bug outlined in https://github.com/elementary/dock/issues/520#top. In an effort to triple check that my local build was working correct, I made a local change to App.vala on my machine. To do this I did the following:
- Cloned the repo
- Downloaded your app.vala raw file from this PR
- I changed the label on line 251 to include "this is a test" before building the application locally
My goal was to make 100% sure that the build I was using, indeed had your patches in there....which it did. I then went ahead and ran my tests in https://github.com/elementary/dock/issues/520#issuecomment-3566792866
Anyways, this is a screenshot of what I would see when I used this patched app.vala with my own change to the context menu item.
I renamed app.vala to app.vala.txt so the upload to github would work. But yea, it's the same file minus line 251.