applications-menu icon indicating copy to clipboard operation
applications-menu copied to clipboard

AppButton: Fix drag to dock

Open danirabbit opened this issue 7 months ago • 4 comments

Fixes #614

Don't close the menu until after drag operation is completed

danirabbit avatar May 28 '25 17:05 danirabbit

For me the dock doesn't seem to accept DND and can't confirm if the issue is fixed :thinking:

https://github.com/user-attachments/assets/af8fb742-e083-478c-ae28-b717852cad30

ryonakano avatar May 29 '25 11:05 ryonakano

@ryonakano I should mention I'm testing on Wayland. I didn't test for X11

danirabbit avatar May 29 '25 13:05 danirabbit

Yes, I also tested on Wayland. It looks like this not always happens but keeping apps in the dock from the secondary menu does not seem to persistent when it happens and opening the secondary menu again disappear the app from the dock:

https://github.com/user-attachments/assets/748f1f5a-bcf6-43a7-a743-158d73ce1fde

But this disappear issue is reproducible in latest master too (81336c1b03b82a7de26f1ca431e326826fa0c1a6) thus I don't think it would be a regression from this branch.

ryonakano avatar May 30 '25 13:05 ryonakano

For me the dock doesn't seem to accept DND and can't confirm if the issue is fixed 🤔

For me this happens about 80% on Wayland and 100% on X, so I can't confirm if this PR does fix the linked issue actually

ryonakano avatar May 30 '25 13:05 ryonakano