appcenter-reviews icon indicating copy to clipboard operation
appcenter-reviews copied to clipboard

Published 20 hours ago • verified publisher icon elementary

Enforce that AppData URLs have a protocol

Open cassidyjames opened this issue 7 years ago • 2 comments

Right now AppData URLs (i.e. issue tracker, homepage, translations) can be inserted without protocols; see https://github.com/mubitosh/qrshare/pull/22. This means they aren't actually usable inside of AppCenter. We should enforce the inclusion of protocols with a test in Houston.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

cassidyjames avatar Jan 07 '18 17:01 cassidyjames

We were hit again by an issue that broke builds in appcenter-web: https://github.com/elementary/appcenter-web/commit/5211529f77fa383ada251f858615b7bcc29c932b#diff-bb395e7f937561bf67ebfcd89b29dd89R7

cassidyjames avatar Oct 20 '18 20:10 cassidyjames

To be clear, that was not an issue with a protocol, but urls that point to files that don't exist.

btkostner avatar Oct 20 '18 21:10 btkostner