elementary icon indicating copy to clipboard operation
elementary copied to clipboard

Teradata support

Open sambloom92 opened this issue 2 years ago • 4 comments

Is your feature request related to a problem? Please describe. Please could Elementary develop support for Teradata?

Describe the solution you'd like Elementary supports Teradata

Describe alternatives you've considered Writing my own adapter dispatch macros for Teradata

Additional context I have not tested Teradata support extensively, but following the quick-start guide and running dbt run --select elementary gives the following error:

In dispatch: No macro named 'complete_buckets_cte' found

This implies that complete_buckets_cte doesn't have a default__ or teradata__ implementation.

Would you be willing to contribute this feature? I am willing to help contribute

sambloom92 avatar Jun 12 '23 09:06 sambloom92

The lack of a default__ implementation for this macro is problematic since merely adding this dbt package to your project will cause a compilation failure if you try to run against an unsupported adapter even if you have elementary disabled for that target. Our project uses one supported adapter and one unsupported adapter. A default impl that does nothing would be really nice.

stocks29 avatar Jun 16 '23 22:06 stocks29

Hi @stocks29 and @sambloom92 , thanks for the feedback! I added a default for complete_buckets_cte: https://github.com/elementary-data/dbt-data-reliability/pull/380

@elongl will do a quick check to see if we missed setting a default in another macro as well.

Maayan-s avatar Jun 20 '23 07:06 Maayan-s

thanks for the quick turnaround @Maayan-s ! any thoughts on when we might expect an updated release which contains this fix?

stocks29 avatar Jun 20 '23 14:06 stocks29

@stocks29 4 hours ago 🙃

Maayan-s avatar Jun 21 '23 12:06 Maayan-s