elementary icon indicating copy to clipboard operation
elementary copied to clipboard

Tests configuration changes

Open Maayan-s opened this issue 3 years ago • 2 comments

The key for choosing specific tests today has the same name as the test. We got feedback that this is confusing and inconsistent between tests.

# Current format:

        - elementary.all_columns_anomalies:
            all_columns_anomalies:
              - null_count

# Suggested format:

        - elementary.all_columns_anomalies:
            monitors:
              - null_count

Also - we should accept the param 'all' as another option to activate all the monitors, as this is more intuitive than all by default.

Maayan-s avatar Apr 19 '22 13:04 Maayan-s

hey @Maayan-s is this something that is open for contribution? I would be interested in helping with this or another issue, do you have any advice on where to start with this enhancement?

Ecalzo avatar May 07 '22 16:05 Ecalzo

Hi @Ecalzo! we are defiantly open for contributions and I'd love to help with guidance and questions (also feel free to reach out anytime here or on Slack). This specific issue introduces a breaking change to the way users configure monitors and therefore requires some extra thinking on how to keep backwards compatibility. We will think about it in the next few days and document the conclusions here.

In the meantime, here are some additional issues that could be a good fit and in similar areas in the code (both have detailed design descriptions) -

Once you feel comfortable with the changes I'd be happy to help with opening a PR and running the tests. Thanks!

oravi avatar May 07 '22 20:05 oravi

This issue is stale because it has been open for too long with no activity. If you would like the issue to remain open, please remove the stale label or leave a comment.

github-actions[bot] avatar Dec 09 '22 02:12 github-actions[bot]