elementary icon indicating copy to clipboard operation
elementary copied to clipboard

[ELE-291] Group and filter tests by tags

Open joostboon opened this issue 2 years ago • 9 comments

We would love to group our tests based on tags. We have different dimensions (accuracy/completeness/uniqueness/etc.). Now we can see the model tags, but not the test tags.

Visually it would be great if we could see the different test tags in the UI. Ideally as a next step we would love to group/sort by tags.

ELE-55

joostboon avatar Oct 28 '22 12:10 joostboon

oh no

RoiTabach avatar Mar 16 '23 19:03 RoiTabach

Sorry, unlinked

RoiTabach avatar Mar 16 '23 19:03 RoiTabach

I also have a use case where I need to be able to send slack alerts for custom tests as over half of our testing for our data mart are custom tests that include business logic and it would be nice to alert if our business logic is failing.

TwBridges avatar Mar 17 '23 13:03 TwBridges

I have the same use case as @joostboon! Would be great if we could use this to group test based on tags

evelinasamuelsson avatar Apr 20 '23 14:04 evelinasamuelsson

https://elementary-community.slack.com/archives/C02CTC89LAX/p1678964139198919

Maayan-s avatar Apr 23 '23 08:04 Maayan-s

@Maayan-s Does that solve this problem. I have my test tagged like this:

models:
  - name: some name
    tests:
      - some-test:
          tags: "some-tag"

dbt recognizes this tag but it doesn't show up in the elementary ui. We use this tag for tests that we want to include but haven't been fully vetted so it can make our dashboard pretty noisy.

cooley-hi avatar Apr 23 '23 21:04 cooley-hi

Hi @cooley-hi , the issue here is just what you described - dbt supports adding tags to tests, but Elementary currently ignores these tags and only uses models tags. We want to change that :)

Maayan-s avatar Apr 23 '23 21:04 Maayan-s

💯

On Sun, Apr 23, 2023 at 2:21 PM Maayan Salom @.***> wrote:

Hi @cooley-hi https://github.com/cooley-hi , the issue here is just what you described - dbt supports adding tags to tests, but Elementary currently ignores these tags and only uses models tags. We want to change that :)

— Reply to this email directly, view it on GitHub https://github.com/elementary-data/elementary/issues/369#issuecomment-1519171222, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZQ6OJ4LGVKN3JAQHJ3R5ZLXCWMORANCNFSM6AAAAAARRBO2UE . You are receiving this because you were mentioned.Message ID: @.***>

--

Matt Cooley

Data Engineer

877 475 0179

Join our team https://bit.ly/3kMVeWv

Human Interest Inc. (“Human Interest http://www.humaninterest.com") is a 401(k) provider that gives small and medium-sized businesses access to low-cost, high-quality retirement plans that make it easy to start saving for your future. Human Interest's investment advisory services are provided for a fee by Human Interest Advisors, LLC ("HIA"), a subsidiary of Human Interest. See full disclosures https://humaninterest.com/disclosures.

cooley-hi avatar Apr 29 '23 01:04 cooley-hi

I'm also running into this issue, I'm trying to filter based on business cases, and not every data quality requirement from the source or model applies to the business cases.

Geuchies avatar Aug 29 '23 13:08 Geuchies