Unlimit numpy
See #1962
Summary by CodeRabbit
- Chores
- Relaxed the project's numpy version requirement to allow any released version.
- This may change dependency resolution or installation outcomes; no functional changes to the product's behavior are expected.
Walkthrough
Changed the numpy dependency specification in pyproject.toml from "<2.0.0" to "*". No other files or control flow were modified.
Changes
| Cohort / File(s) | Change Summary |
|---|---|
Dependency version changepyproject.toml |
Updated numpy in [tool.poetry.dependencies] from "<2.0.0" to "*" (removed the upper-bound constraint). |
Sequence Diagram(s)
Not applicable β no runtime control-flow or new feature introduced.
Estimated code review effort
π― 1 (Trivial) | β±οΈ ~2 minutes
- Files to check:
pyproject.toml(ensure only the numpy version spec was changed and formatting remained valid).
Poem
I munched the bounds, let versions roam,
A hop, a twitch β the pod feels home.
Loose as clover, paws on air,
NumPy now may go anywhere. ππ±
Pre-merge checks and finishing touches
β Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | β Passed | Check skipped - CodeRabbitβs high-level summary is enabled. |
| Title check | β Passed | The title 'Unlimit numpy' directly and clearly describes the main change: removing the upper bound constraint from the numpy dependency specification. |
| Docstring Coverage | β Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
β¨ Finishing touches
π§ͺ Generate unit tests (beta)
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
π Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
π₯ Commits
Reviewing files that changed from the base of the PR and between 87df3feb9fd72ab6d493159c24a314100e48d51e and dbe1e0498a74abe32d03c27b36efa7f12e042ad6.
π Files selected for processing (1)
pyproject.toml(1 hunks)
π§ Files skipped from review as they are similar to previous changes (1)
- pyproject.toml
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
π @CloutKhan
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.
It's been a while ~ I remember checking back when I made this that numpy would be included in the last several versions of dbt-core, but going back to look for it I can't actually see numpy listed in older versions of the core/setup.py in https://github.com/dbt-labs/dbt-core ~ so I've changed this from removing the dependency entirely to keeping it but unlimiting the specifier.
I tried to fix a little bit differently: https://github.com/elementary-data/elementary/pull/2074 @arbiv could you review it, pls?
resolved in https://github.com/elementary-data/elementary/pull/2074