elementary icon indicating copy to clipboard operation
elementary copied to clipboard

Unlimit numpy

Open CloutKhan opened this issue 5 months ago β€’ 3 comments

See #1962

Summary by CodeRabbit

  • Chores
    • Relaxed the project's numpy version requirement to allow any released version.
    • This may change dependency resolution or installation outcomes; no functional changes to the product's behavior are expected.

CloutKhan avatar Jul 18 '25 04:07 CloutKhan

Walkthrough

Changed the numpy dependency specification in pyproject.toml from "<2.0.0" to "*". No other files or control flow were modified.

Changes

Cohort / File(s) Change Summary
Dependency version change
pyproject.toml
Updated numpy in [tool.poetry.dependencies] from "<2.0.0" to "*" (removed the upper-bound constraint).

Sequence Diagram(s)

Not applicable β€” no runtime control-flow or new feature introduced.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Files to check: pyproject.toml (ensure only the numpy version spec was changed and formatting remained valid).

Poem

I munched the bounds, let versions roam,
A hop, a twitch β€” the pod feels home.
Loose as clover, paws on air,
NumPy now may go anywhere. πŸ‡πŸŒ±

Pre-merge checks and finishing touches

βœ… Passed checks (3 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed The title 'Unlimit numpy' directly and clearly describes the main change: removing the upper bound constraint from the numpy dependency specification.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
πŸ§ͺ Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

πŸ“œ Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 87df3feb9fd72ab6d493159c24a314100e48d51e and dbe1e0498a74abe32d03c27b36efa7f12e042ad6.

πŸ“’ Files selected for processing (1)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Jul 18 '25 04:07 coderabbitai[bot]

πŸ‘‹ @CloutKhan Thank you for raising your pull request. Please make sure to add tests and document all user-facing changes. You can do this by editing the docs files in this pull request.

github-actions[bot] avatar Jul 18 '25 04:07 github-actions[bot]

It's been a while ~ I remember checking back when I made this that numpy would be included in the last several versions of dbt-core, but going back to look for it I can't actually see numpy listed in older versions of the core/setup.py in https://github.com/dbt-labs/dbt-core ~ so I've changed this from removing the dependency entirely to keeping it but unlimiting the specifier.

CloutKhan avatar Nov 13 '25 23:11 CloutKhan

I tried to fix a little bit differently: https://github.com/elementary-data/elementary/pull/2074 @arbiv could you review it, pls?

vyagubov avatar Dec 15 '25 12:12 vyagubov

resolved in https://github.com/elementary-data/elementary/pull/2074

arbiv avatar Dec 18 '25 08:12 arbiv