--update-dbt-package not respected
Describe the bug
edr send-report will always run dbt deps, even if --update-dbt-package has been set to false. This generates errors in situations where there are private packages and the elementary does not have access to this.
In our case elementary is triggered from a Cloud Run instance, that has already the packages set up.
It will even run dbt deps if the versions match.
To Reproduce Steps to reproduce the behavior:
- Create an private package
- Add private package to dbt repo with git method
- Add token to env and run dbt deps
- Remove token from env
- Run
edr send-reportoredr send-report --update-dbt-package false - See error
Expected behavior edr send-report will function without trying to update the internal packages.
Environment (please complete the following information):
- Elementary CLI (edr) version: 0.19.3
- Elementary dbt package version: 0.19.1
- dbt version you're using: 1.10.1
- Data warehouse: BigQuery
Additional context Log:
edr internal dbt package is not up-to-date, updating it...
INFO Running dbt command --log-format json deps --project-dir /dbt --profiles-dir /dbt/profiles/
{"data": {"exc": "Internal Error Error checking out spec=\'None\' for repo <redacted_package_name>.git
Would you be willing to contribute a fix for this issue? Willing to contribute. Tried following the code but got lost. Did find:
- monitor cli has the default False.
- dbt runner has default True.
But in between its unclear what happens.
@kverburg thanks for reporting this issue! We will look into it
This flag was created to serve a different purpose. It should be set to true if you want to force running dbt deps. It doesn't disable running deps when set to false, which is also the default. We will check your specific use case and why dbt deps is triggered.
This issue is stale because it has been open for too long with no activity. If you would like the issue to remain open, please remove the stale label or leave a comment.
This issue was closed because it has been inactive for too long while being marked as stale. If you would like the issue to reopen, please leave a comment.