elementary icon indicating copy to clipboard operation
elementary copied to clipboard

Issue with freshness test display on Elementary dashboard

Open arjunanandkumar opened this issue 1 year ago • 2 comments

Describe the bug We had a jump in versions from v0.14.1 to v0.15.1 due to an oversight in our deployment script. That's been sorted, and things work fine for the most part except how freshness tests are shown on the dashboard. It looks like elementary now sees the freshness test as both a generic, and freshness type test as opposed to just freshness before.

Old version: image

New: image

Notice the 1 of each kind of test detected on most of these models. We haven't changed anything in the model specifically, and the freshness test is the only kind of test defined on it:

models:
  - name: engage_campaign_members
    description: desc
    tests:
      - elementary.freshness_anomalies:
          timestamp_column: created
          config:
            severity: warn

To Reproduce Steps to reproduce the behavior:

  1. Go to the elementary dashboard.
  2. Click on the tests under "Freshness"
  3. Test type "generic" is displayed instead of freshness.
  4. But, if you navigate to the model where the freshness test is added, it correctly shows that the test type is freshness rather than generic.

Expected behavior It is expected that only the freshness test shows up in this view.

Screenshots Previous: image Current: image

Environment (please complete the following information):

  • Elementary CLI (edr) version: v0.15.1
  • Elementary dbt package version: 0.13.2
  • dbt version you're using: 1.8.1
  • Data warehouse Snowflake
  • Infrastructure details: dev and prod

Would you be willing to contribute a fix for this issue? I am happy to contribute if I can get some guidelines.

arjunanandkumar avatar Jun 20 '24 07:06 arjunanandkumar

Hi @arjunanandkumar , Thanks for submitting the issue. Other than the different "test type" values, did you notice any change in behavior? Are the results the same?

ellakz avatar Jun 20 '24 12:06 ellakz

Hi @ellakz, Besides that, there is no change in behavior. I can see that it has run and passed if I navigate directly to the model where the freshness test is defined (Indicated by the green "1").

arjunanandkumar avatar Jun 20 '24 12:06 arjunanandkumar

Hi @ellakz, I was wondering if you had any new insight on this.

arjunanandkumar avatar Jul 04 '24 08:07 arjunanandkumar

Hey again @ellakz, we've located the issue. We completely oversaw this warning: WARNING — You are using incompatible versions between edr (0.15.1) and Elementary's dbt package (0.13.2).

And this is something we have forgotten to handle on our end after we upgraded to dbt 1.8. I will close down this issue now.

arjunanandkumar avatar Jul 05 '24 08:07 arjunanandkumar

Thanks for updating @arjunanandkumar !

ellakz avatar Jul 07 '24 11:07 ellakz