elementary icon indicating copy to clipboard operation
elementary copied to clipboard

--disable-samples should only hide the results of generic and singular tests, not graphs of freshness or volume tests

Open bebbo203 opened this issue 1 year ago • 1 comments

Describe the bug The --disable-sample flag is intended to hide samples for failing tests, which is crucial when PII data is present in the tested table. However, it should not hide graphs related to freshness and volume tests since these do not contain PII.

To Reproduce Steps to reproduce the behavior:

  1. Set up some freshness and volume tests in your models
  2. Run edr report --disable-samples true
  3. Open the generated dashboard and click on the freshness or volume tests
  4. Not enough data to calculate anomaly score is displayed instead of the graph for every volume or freshness test.

Expected behavior The --disable-sample flag should only hide samples for singular and generic tests, not for freshness and volume tests.

Screenshots Senza titolo

Environment (please complete the following information):

  • edr Version: 0.15.0
  • dbt package Version: 0.15.0

bebbo203 avatar May 22 '24 11:05 bebbo203

Hi @bebbo203 ! Thanks for reporting this, I believe you are correct, I can confirm this is a bug. If you're willing to contribute I believe it should be a simple fix.

haritamar avatar May 28 '24 21:05 haritamar