elementary icon indicating copy to clipboard operation
elementary copied to clipboard

Clicking on dbt tests link from dashboard redirects to tests page but with source freshness NOT excluded

Open adamcunnington-mlg opened this issue 1 year ago • 2 comments

Describe the bug When you click on the numbered links on dashboard screen, they take you to the test execution history, filtered to relevant section. This works as expected most of the time - e.g. if you click here: image ... you get redirected here: image

However, when you click on the numbered links below the "dbt tests" section of dashboard, source freshness is NOT excluded in the destination you are redirected to and so you see many more results than the number you clicked on.

Strangely, there is a filter active on the test name column even though everything is selected including source freshness? image

To Reproduce Obvious.

Expected behavior Obvious.

Screenshots Above

Environment (please complete the following information):

  • edr version: Most recent
  • dbt package Version: 0.14.1

Additional context Add any other context about the problem here.

adamcunnington-mlg avatar May 14 '24 13:05 adamcunnington-mlg

Hi @adamcunnington-mlg ! Currently this happens because technically "source freshness" belongs to both categories (being a dbt test and also a type of freshness). That being said, we understand the confusion and it probably makes sense to only include it under the freshness category.

Regarding the filter - it filters on every test originating from dbt. If you had Elementary anomaly tests in your suite, they wouldn't be included in the filter.

haritamar avatar May 15 '24 11:05 haritamar

Thanks for the response. Ok noted on the filter w.r.t excluding anomolies.

But yes, please do filter freshness out here - I think it makes sense and would ensure consistency between dash and the filters - as it is everywhere else.

adamcunnington-mlg avatar May 15 '24 12:05 adamcunnington-mlg