elementary icon indicating copy to clipboard operation
elementary copied to clipboard

[ELE-2165] No error message on channel ID not found in send report

Open noaKurman opened this issue 2 years ago • 0 comments

Describe the bug (https://elementary-community.slack.com/archives/C02CTC89LAX/p1702480558077509?thread_ts=1678995868.791089&cid=C02CTC89LAX)

To Reproduce edr send-report set channel name containing the leading #

Expected behavior A clear error message the channel ID was not found Though since sending the file requires a channel ID and the search is based on the channel name the channel id is not found because of the leading # - the message is being sent to the channel, making you think all is well, while the report send is failing with no additional information

Screenshots

image

Additional context I'd think there are three possible action items here:

  1. Better logging in case the channel ID is not found in the _get_channel_id function
  2. Shouldn’t send an empty channel ID if one is not found (in send_file)
  3. Adding a flag for channel_id is also possible for people who don’t want to wait for the search

From SyncLinear.com | ELE-2165

noaKurman avatar Dec 14 '23 08:12 noaKurman