elementary icon indicating copy to clipboard operation
elementary copied to clipboard

Add "test alerting" on Slack

Open Maayan-s opened this issue 3 years ago • 4 comments

Slack alerts are only sent if there are failed tests. When users deploy Elementary, they want to have a way to validate the deployment worked. We should have a flag for validating the deployment.

Maayan-s avatar Jul 18 '22 17:07 Maayan-s

Looks interesting I would be happy to take this. How would you classify a successful deployment?

ronmorgen1 avatar Aug 24 '22 16:08 ronmorgen1

@ronmorgen1

Important background - the CLI has an internal dbt project. This project queries the Elementary tables from the dbt package deployment. So the flow is:

  1. User installs the dbt package, that collects data to an elementary schema
  2. The CLI has an internal dbt project, with a profile pointing at the elementary schema
  3. The CLI dbt project runs and reads data that should be sent as alerts
  4. The CLI sends alerts to Slack

So a successful deployment means that the elementary schema exists, the CLI can read from it (the profile is well configured), and the CLI can find a Slack config and send a message.

Maayan-s avatar Aug 24 '22 20:08 Maayan-s

@Maayan-s

I see. So after the CLI installation when the user runs the command edt monitor, a slack message is sent only when tests fail, and now we want to send one when deployment is successful (?)

ronmorgen1 avatar Aug 25 '22 13:08 ronmorgen1

@ronmorgen1

I think we should probably have a --test flag. The use case here is that you install but don't have any failed tests at the moment, but you still want to make sure the deployment actually works.

Maayan-s avatar Aug 25 '22 14:08 Maayan-s

This issue is stale because it has been open for too long with no activity. If you would like the issue to remain open, please remove the stale label or leave a comment.

github-actions[bot] avatar Dec 03 '22 02:12 github-actions[bot]

Added as edr monitor --test.

 --test BOOLEAN                  Whether to send a test message in case there
                                  are no alerts.

elongl avatar Dec 04 '22 20:12 elongl