element-plus icon indicating copy to clipboard operation
element-plus copied to clipboard

fix(Component): [cascader] Selected height

Open zzjiaxiang opened this issue 1 year ago โ€ข 11 comments

fix #18282 fix #18316 fix #18584 about #13017

zzjiaxiang avatar Sep 15 '24 18:09 zzjiaxiang

๐Ÿ‘‹ @zzjiaxiang, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

github-actions[bot] avatar Sep 15 '24 18:09 github-actions[bot]

Hello @zzjiaxiang, thank you for contributing to element-plus, please see our guideline to see how to make contribution

github-actions[bot] avatar Sep 15 '24 18:09 github-actions[bot]

Open in Stackblitz

pnpm add https://pkg.pr.new/element-plus/element-plus@18285

commit: 8e2fd01

pkg-pr-new[bot] avatar Sep 20 '24 08:09 pkg-pr-new[bot]

๐Ÿงช Playground Preview: https://element-plus.run/?pr=18285 Please comment the example via this playground if needed.

github-actions[bot] avatar Sep 20 '24 08:09 github-actions[bot]

The interval between tags is larger compared to Select component, and it is best to maintain consistency.

Demo

tolking avatar Sep 23 '24 08:09 tolking

The interval between tags is larger compared to Select component, and it is best to maintain consistency.

Demo

I fixed it @tolking

zzjiaxiang avatar Sep 23 '24 08:09 zzjiaxiang

Both choices make sense, which one should we choose? @tolking @warmthsea @btea

zzjiaxiang avatar Sep 25 '24 16:09 zzjiaxiang

IMO, It is better to maintain consistency with the Select components. latest design

tolking avatar Oct 09 '24 07:10 tolking

I don't know if there is something wrong with the link I visited, I don't see any design diagram of the cascader component when an option is selected.

btea avatar Oct 09 '24 13:10 btea

The Select components is a new design.

tolking avatar Oct 10 '24 09:10 tolking

This problem seems to exist still when the size value is small.

btea avatar Nov 16 '24 14:11 btea

Maintained consistency with the Select component style.

preview

zzjiaxiang avatar Nov 17 '24 02:11 zzjiaxiang

This problem seems to exist still when the size value is small.

done

zzjiaxiang avatar Nov 17 '24 02:11 zzjiaxiang

When set to filterable, the input box seems to cause the bottom margin to be too large, and the input box does not seem aligned with the label. link

QQ_1731940376527

btea avatar Nov 18 '24 14:11 btea

@tolking @btea

After the change, the cursor and label of the new row are at the same distance from the left border, but they look very close. Do you think this is reasonable? (Select has always been like this)

Select

image

Before Cascader

image

After Cascader

image

warmthsea avatar Nov 19 '24 13:11 warmthsea

IMO, the revised style is more reasonable.

btea avatar Nov 19 '24 14:11 btea

I support keeping the style consistent

tolking avatar Nov 20 '24 02:11 tolking

What else needs to be done to merge into the dev branch ?

zzjiaxiang avatar Nov 22 '24 12:11 zzjiaxiang