element-plus
element-plus copied to clipboard
fix(Component): [cascader] Selected height
๐ @zzjiaxiang, seems like this is your first time contribution to element-plus.
- Please make sure that you have read our guidelines and code of conduct before making a contribution.
- You can comment with
/label Components:[component_name]to add a label for which component you are working on. - You may join our
for staying tuned.
Hello @zzjiaxiang, thank you for contributing to element-plus, please see our guideline to see how to make contribution
๐งช Playground Preview: https://element-plus.run/?pr=18285 Please comment the example via this playground if needed.
The interval between tags is larger compared to Select component, and it is best to maintain consistency.
The interval between tags is larger compared to Select component, and it is best to maintain consistency.
I fixed it @tolking
Both choices make sense, which one should we choose? @tolking @warmthsea @btea
IMO, It is better to maintain consistency with the Select components. latest design
I don't know if there is something wrong with the link I visited, I don't see any design diagram of the cascader component when an option is selected.
The Select components is a new design.
This problem seems to exist still when the size value is small.
This problem seems to exist still when the size value is
small.
done
When set to filterable, the input box seems to cause the bottom margin to be too large, and the input box does not seem aligned with the label. link
@tolking @btea
After the change, the cursor and label of the new row are at the same distance from the left border, but they look very close. Do you think this is reasonable? (Select has always been like this)
Select
Before Cascader
After Cascader
IMO, the revised style is more reasonable.
I support keeping the style consistent
What else needs to be done to merge into the dev branch ?
