element-plus icon indicating copy to clipboard operation
element-plus copied to clipboard

feat(components): [container] add validation for the `direction` prop

Open chenyuqiua opened this issue 1 year ago • 4 comments

  • I found that the orientation attribute of the Container component was not validated.
  • So I added enumeration value validation to the component.

Please make sure these boxes are checked before submitting your PR, thank you!

  • [x] Make sure you follow contributing guide English | (中文 | Español | Français).
  • [x] Make sure you are merging your commits to dev branch.
  • [ ] Add some descriptions and refer to relative issues for your PR.

chenyuqiua avatar Apr 30 '24 16:04 chenyuqiua

👋 @chenyuqiua, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Hello @chenyuqiua, thank you for contributing to element-plus, please see our guideline to see how to make contribution

github-actions[bot] avatar Apr 30 '24 16:04 github-actions[bot]

github-actions[bot] avatar Apr 30 '24 16:04 github-actions[bot]

🧪 Playground Preview: https://element-plus.run/?pr=16734 Please comment the example via this playground if needed.

github-actions[bot] avatar May 01 '24 02:05 github-actions[bot]