element-plus icon indicating copy to clipboard operation
element-plus copied to clipboard

fix(components): [menu] Fixing Menu component's flickering issue with surplus sub-items on insufficient page height.

Open ikkkp opened this issue 1 year ago • 9 comments

fix:#15308

ikkkp avatar Feb 06 '24 15:02 ikkkp

👋 @ikkkp, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Hello @ikkkp, thank you for contributing to element-plus, please see our guideline to see how to make contribution

github-actions[bot] avatar Feb 06 '24 15:02 github-actions[bot]

github-actions[bot] avatar Feb 06 '24 15:02 github-actions[bot]

It seems that something went wrong with pnpm lint. Maybe you should execute ~~pnpm format~~ pnpm lint:fix.

Sorry, I seemed to have written it wrong just now. You should probably adjust it. @ikkkp

btea avatar Feb 07 '24 04:02 btea

🧪 Playground Preview: https://element-plus.run/?pr=15836 Please comment the example via this playground if needed.

github-actions[bot] avatar Feb 07 '24 04:02 github-actions[bot]

It seems that something went wrong with pnpm lint. Maybe you should execute ~pnpm format~ pnpm lint:fix.

Sorry, I seemed to have written it wrong just now. You should probably adjust it. @ikkkp

I have just run pnpm lint:fix

ikkkp avatar Feb 07 '24 05:02 ikkkp

Hello, can you simplify the commit message and translate it into English? Thanks.

btea avatar Feb 07 '24 05:02 btea

Hello, can you simplify the commit message and translate it into English? Thanks.

Sure

ikkkp avatar Feb 07 '24 05:02 ikkkp

@ikkkp I see you modified content outside of the menu component, a PR should only solve one problem, if you want to solve other problems, maybe you should create a new PR.

btea avatar Feb 07 '24 13:02 btea

@ikkkp I see you modified content outside of the menu component, a PR should only solve one problem, if you want to solve other problems, maybe you should create a new PR.

Would it be possible to merge this PR at this time?Or does it require further modifications? @btea

ikkkp avatar Feb 21 '24 05:02 ikkkp

Don't worry, you need to wait for others to review it.

btea avatar Feb 21 '24 05:02 btea