element-plus
element-plus copied to clipboard
fix(components): [menu] Fixing Menu component's flickering issue with surplus sub-items on insufficient page height.
fix:#15308
👋 @ikkkp, seems like this is your first time contribution to element-plus.
- Please make sure that you have read our guidelines and code of conduct before making a contribution.
- You can comment with
/label Components:[component_name]to add a label for which component you are working on. - You may join our
for staying tuned.
Hello @ikkkp, thank you for contributing to element-plus, please see our guideline to see how to make contribution
It seems that something went wrong with pnpm lint. Maybe you should execute ~~pnpm format~~ pnpm lint:fix.
Sorry, I seemed to have written it wrong just now. You should probably adjust it. @ikkkp
🧪 Playground Preview: https://element-plus.run/?pr=15836 Please comment the example via this playground if needed.
It seems that something went wrong with
pnpm lint. Maybe you should execute ~pnpm format~pnpm lint:fix.Sorry, I seemed to have written it wrong just now. You should probably adjust it. @ikkkp
I have just run pnpm lint:fix
Hello, can you simplify the commit message and translate it into English? Thanks.
Hello, can you simplify the commit message and translate it into English? Thanks.
Sure
@ikkkp I see you modified content outside of the menu component, a PR should only solve one problem, if you want to solve other problems, maybe you should create a new PR.
@ikkkp I see you modified content outside of the menu component, a PR should only solve one problem, if you want to solve other problems, maybe you should create a new PR.
Would it be possible to merge this PR at this time?Or does it require further modifications? @btea
Don't worry, you need to wait for others to review it.
