element-plus fix(theme-chalk): replace `gulp-clean-css` with `clean-css`

fix(theme-chalk): replace `gulp-clean-css` with `clean-css`

Open zhixiaotong opened this issue 1 year ago • 8 comments

fixed #15686

Please make sure these boxes are checked before submitting your PR, thank you!

[ ] Make sure you follow contributing guide English | (中文 | Español | Français).
[ ] Make sure you are merging your commits to dev branch.
[ ] Add some descriptions and refer to relative issues for your PR.

Feb 01 '24 04:02 zhixiaotong

👋 @zhixiaotong, seems like this is your first time contribution to element-plus.

Please make sure that you have read our guidelines and code of conduct before making a contribution.
You can comment with /label Components:[component_name] to add a label for which component you are working on.
You may join our for staying tuned.

Feb 01 '24 04:02 pull-request-triage[bot]

Hello @zhixiaotong, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Feb 01 '24 04:02 github-actions[bot]

由于上面测试都锁定了lockfile，导致部分测试失败，原因是我修改了package.json。麻烦你了，这个怎么处理呢？@kooriookami

Feb 01 '24 05:02 zhixiaotong

Maybe you should commit the pnpm-lock.yaml file synchronously.

Feb 01 '24 05:02 btea

Maybe you should commit the pnpm-lock.yaml file synchronously.

OK，感谢回复和解答。

Feb 01 '24 06:02 zhixiaotong

🧪 Playground Preview: https://element-plus.run/?pr=15748 Please comment the example via this playground if needed.

Feb 01 '24 06:02 github-actions[bot]

Done, if you agree with the idea in https://github.com/element-plus/element-plus/issues/15686, please review it by the way，thx. ^_^@btea

Feb 01 '24 06:02 zhixiaotong