element-plus-vite-starter icon indicating copy to clipboard operation
element-plus-vite-starter copied to clipboard

feat: (action) Cache node modules

Open h7ml opened this issue 2 years ago • 5 comments

feat: (action) Cache node modules

h7ml avatar May 31 '22 20:05 h7ml

Use caching to speed up the build of actions. Improved dependency package installation time by approximately 60%

h7ml avatar May 31 '22 20:05 h7ml

Use caching to speed up the build of actions. Improved dependency package installation time by approximately 60%

image

h7ml avatar May 31 '22 20:05 h7ml

We didn't add a dependency to it before, partly because we didn't want to pin a package manager.

package-lock.json / yarn.lock / pnpm-lock.yaml

YunYouJun avatar Jun 01 '22 10:06 YunYouJun

Maybe we need to discuss.

YunYouJun avatar Jun 01 '22 10:06 YunYouJun

As a starter / template, I think the better way is to ignore or exclude lock file, and then the template is always up-to-date. Besides, I don't think we should make a specific package manager as default. It's up to users.

sxzz avatar Jul 22 '22 10:07 sxzz

For now, it may not be necessary, but if caching is needed, I actually prefer PNPM, which has a smaller and faster lockfile.

YunYouJun avatar Aug 13 '22 08:08 YunYouJun