synapse icon indicating copy to clipboard operation
synapse copied to clipboard

complement.sh: don't use remote base synapse image

Open AndrewFerr opened this issue 10 months ago • 1 comments

This PR is because I hit issues with the Complement script's attempt to build the synapse-workers image, as Docker refused to build it from my local matrixdotorg/synapse image & insisted on using the latest remote synapse image from Docker Hub instead.

As it turns out, this was because my Docker build driver was something other than docker, which is what's needed to let FROM <image> prefer local images: https://github.com/docker/buildx/issues/159#issuecomment-539238262

Reinstalling Docker from upstream repos (as opposed to Fedora's) lets the workers image build as intended, meaning this PR is only needed for compatibility with other build drivers.

Pull Request Checklist

  • [x] Pull request is based on the develop branch
  • [x] Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • [x] Code style is correct (run the linters)

AndrewFerr avatar Mar 04 '25 15:03 AndrewFerr

This PR is because I hit issues with the Complement script's attempt to build the synapse-workers image, as Docker refused to build it from my local matrixdotorg/synapse image & insisted on using the latest remote synapse image from Docker Hub instead.

As it turns out, this was because my Docker build driver was something other than docker, which is what's needed to let FROM <image> prefer local images: https://github.com/docker/buildx/issues/159#issuecomment-539238262

Reinstalling Docker from upstream repos (as opposed to Fedora's) lets the workers image build as intended, meaning this PR is only needed for compatibility with other build drivers.

AndrewFerr avatar Apr 02 '25 15:04 AndrewFerr

Closing this because the root cause of my build issues was my Docker configuration: https://github.com/element-hq/synapse/pull/18210#discussion_r2499646952

This PR could still be used to make builds compatible with the kind of config I had, but it's not the responsibility of this repo to cover non-standard configs.

AndrewFerr avatar Nov 06 '25 16:11 AndrewFerr