synapse icon indicating copy to clipboard operation
synapse copied to clipboard

MSC4140: don't cancel delayed state on own state

Open AndrewFerr opened this issue 1 year ago • 1 comments

When a user sends a state event, do not cancel their own delayed events for the same piece of state.

For context, see the relevant section in the MSC.

Pull Request Checklist

  • [x] Pull request is based on the develop branch
  • [x] Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • [x] Code style is correct (run the linters)

AndrewFerr avatar Oct 10 '24 03:10 AndrewFerr

Depends on https://github.com/matrix-org/complement/pull/742 for Complement tests to pass.

AndrewFerr avatar Oct 10 '24 03:10 AndrewFerr

The sytests pass when I run them locally. Is there a way to retry their CI runs?

AndrewFerr avatar Oct 16 '24 17:10 AndrewFerr

@AndrewFerr Retried :+1:

MadLittleMods avatar Oct 16 '24 17:10 MadLittleMods

Now the only failing tests are the ones that depend on https://github.com/matrix-org/complement/pull/742 (finally!).

AndrewFerr avatar Nov 11 '24 05:11 AndrewFerr

@AndrewFerr what's the latest on this PR and addressing any outstanding issues?

hughns avatar Jan 17 '25 14:01 hughns

what's the latest on this PR and addressing any outstanding issues?

This and https://github.com/matrix-org/complement/pull/742 are both ready to be merged (though the latter should be merged first).

EDIT: I'll open a new Complement PR with its branch name set such that it will be used in this PR's Complement tests in CI.

AndrewFerr avatar Jan 17 '25 15:01 AndrewFerr

Eugh, looks like I had the wrong understanding of how CI chooses which Complement branch to run on.

In any case, I can assure you that TestDelayedEvents passes when using this PR + https://github.com/matrix-org/complement/pull/768.

AndrewFerr avatar Mar 10 '25 17:03 AndrewFerr